[immer] update port #19521
Merged
[immer] update port #19521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JonLiu1993
added
the
category:port-update
JonLiu1993
requested changes
Aug 12, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The CI shows a regression, but it seems to be related to my |
vcpkg_cmake_configure and vcpkg_cmake_install provided by vcpkg-cmake port. |
JonLiu1993
requested changes
Aug 13, 2021
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index b0f7b57..9ba7997 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2694,7 +2694,7 @@
},
"immer": {
"baseline": "2021-05-03",
- "port-version": 2
+ "port-version": 0
},
"implot": {
"baseline": "0.11",
diff --git a/versions/i-/immer.json b/versions/i-/immer.json
index 68850cd..0ab115f 100644
--- a/versions/i-/immer.json
+++ b/versions/i-/immer.json
@@ -1,9 +1,9 @@
{
"versions": [
{
- "git-tree": "109831691a62c81c985e8652aa7e1f073d776660",
- "version-string": "2021-05-03",
- "port-version": 2
+ "git-tree": "0ee78459721140ead0ace0a031bbb9d28039b19e",
+ "version-date": "2021-05-03",
+ "port-version": 0
},
{
"git-tree": "515103042c70e0f9cf8d1518816d09fc6110a669",
|
Thanks for your pr,please run command "./vcpkg x-add-version immer --overwrite-version" then commit the changes again |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/i-/immer.json b/versions/i-/immer.json
index f22fb87..0ab115f 100644
--- a/versions/i-/immer.json
+++ b/versions/i-/immer.json
@@ -5,11 +5,6 @@
"version-date": "2021-05-03",
"port-version": 0
},
- {
- "git-tree": "109831691a62c81c985e8652aa7e1f073d776660",
- "version-string": "2021-05-03",
- "port-version": 2
- },
{
"git-tree": "515103042c70e0f9cf8d1518816d09fc6110a669",
"version-string": "2019-06-07",
|
@waybeforenow, If pr is ready for review please let me know |
|
I've marked it as ready for review now. |
JonLiu1993
approved these changes
Aug 16, 2021
JonLiu1993
added
the
category:port-feature
|
Feature docs tested successfully in the following triplet:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Immer port was previously out of date.
Which triplets are supported/not supported? Have you updated the CI baseline?
I have tested
x86-linux, and there appears to be no incompatible triplets.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/